Return correct type form include_i18n!(), don't write duplciate msgids #2

Merged
asonix merged 3 commits from plume/gettext-macros:master into master 2019-01-21 12:18:37 +00:00
asonix commented 2019-01-21 02:36:26 +00:00 (Migrated from github.com)
  • Read the pot file to see if format!("msgid {}", message) exists before writing it. This fixes gettext errors when duplicate msgids are present.
  • Actually return Vec<(&'static str, Catalog)> from include_i18n!() instead of just Vec<Catalog>
  • cargo fmt
- Read the pot file to see if `format!("msgid {}", message)` exists before writing it. This fixes gettext errors when duplicate msgids are present. - Actually return `Vec<(&'static str, Catalog)>` from `include_i18n!()` instead of just `Vec<Catalog>` - `cargo fmt`
elegaanz (Migrated from github.com) approved these changes 2019-01-21 12:09:50 +00:00
elegaanz (Migrated from github.com) left a comment

I already published a 0.2.0 version on crates.io containing a fix for the duplicate message problem, I just forgot to push it to GitHub too. Sorry. 😬 I will try to merge our changes nicely this evening.

And thank you for your help. 🙂

I already published a 0.2.0 version on crates.io containing a fix for the duplicate message problem, I just forgot to push it to GitHub too. Sorry. :grimacing: I will try to merge our changes nicely this evening. And thank you for your help. :slightly_smiling_face:
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: plume/gettext-macros#2
No description provided.