Plume/joinplu.me
5
1
Fork 5
Code Issues 1 Pull requests Releases Wiki Activity

Use ruby instead of JS for instances displaying #51

Merged
KitaitiMakoto merged 4 commits from Marius/joinplu.me:instances-no-js into main 2022-07-23 11:24:02 +00:00
Conversation 2 Commits 4 Files changed 4 +69 -103
Marius commented 2022-07-04 11:11:34 +00:00
Contributor
Copy link

Problem

I noticed the instance displaying is made from javascript, which means that someone disabling it will not see all the plume instances.

Solution

Therefore, i propose to rewrite it in ruby, as it is already used for language list.

This PR also remove the unreachable instances from the list.

Testing

Deploy the website in local (follow the README.md instructions) and verify the website is the same as the one deployed on joinplu.me.

# Problem I noticed the instance displaying is made from javascript, which means that someone disabling it will not see all the plume instances. # Solution Therefore, i propose to rewrite it in ruby, as it is already used for language list. This PR also remove the unreachable instances from the list. # Testing Deploy the website in local (follow the **README.md** instructions) and verify the website is the same as the one deployed on [joinplu.me](joinplu.me).
Marius added 3 commits 2022-07-04 11:11:37 +00:00
Marius added 1 commit 2022-07-04 11:13:24 +00:00
KitaitiMakoto merged commit f25bb73cb5 into main 2022-07-23 11:24:02 +00:00
KitaitiMakoto commented 2022-07-23 11:24:17 +00:00
Owner
Copy link

Great! Thank you!

Great! Thank you!
KitaitiMakoto commented 2022-07-23 12:41:29 +00:00
Owner
Copy link

Deployed.

Deployed.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
dependencies
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: plume/joinplu.me#51
No description provided.
Delete branch "Marius/joinplu.me:instances-no-js"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?