WIP - initial RTL support #575 #577

Merge aplicado

ahangarha aplicou merge dos 9 commits de add-rtl-support em master

ahangarha comentou (Migrado de github.com)

In regard to #575, few fixes have been done so far. Yet, there are many others to be made, including:

BIDI to be applied to form fields (which are rendered dynamically)
fix css styles and remove text-align, modify margin/madding left/right
BIDI to be applied to every elements inside article for post content

In regard to #575, few fixes have been done so far. Yet, there are many others to be made, including: - [x] BIDI to be applied to form fields (which are rendered dynamically) - [ ] fix css styles and remove text-align, modify margin/madding left/right - [ ] BIDI to be applied to every elements inside article for post content

🎉 4

trinity-1686a comentou

Proprietário

if you want to tinker that, forms are rendered using what's in src/template_utils.rs on line 241-249 and 335-336

if you want to tinker that, forms are rendered using what's in `src/template_utils.rs` on line 241-249 and 335-336

👍 1

codecov[bot] comentou (Migrado de github.com)

Codecov Report

Merging #577 into master will decrease coverage by 0.76%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
- Coverage   35.28%   34.51%   -0.77%     
==========================================
  Files          68       67       -1     
  Lines        7899     7872      -27     
  Branches     1891     1890       -1     
==========================================
- Hits         2787     2717      -70     
- Misses       4334     4394      +60     
+ Partials      778      761      -17

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/577?src=pr&el=h1) Report > Merging [#577](https://codecov.io/gh/Plume-org/Plume/pull/577?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/c031804464a22c550ff621483811a202ecbb238c?src=pr&el=desc) will **decrease** coverage by `0.76%`. > The diff coverage is `50%`. ```diff @@ Coverage Diff @@ ## master #577 +/- ## ========================================== - Coverage 35.28% 34.51% -0.77% ========================================== Files 68 67 -1 Lines 7899 7872 -27 Branches 1891 1890 -1 ========================================== - Hits 2787 2717 -70 - Misses 4334 4394 +60 + Partials 778 761 -17 ```

ahangarha comentou (Migrado de github.com)

if you want to tinker that, forms are rendered using what's in src/template_utils.rs on line 241-249 and 335-336

this was really helpful. I made changes and pushed it up. CI ended in failure. was it because of my changes?

> if you want to tinker that, forms are rendered using what's in `src/template_utils.rs` on line 241-249 and 335-336 this was really helpful. I made changes and pushed it up. CI ended in failure. was it because of my changes?

elegaanz comentou (Migrado de github.com)

No it was not your fault, CI fails for no good reasons sometimes. I restarted the failed job, let's hope it will work this time.

👍 1

trinity-1686a comentou

Proprietário

BIDI to be applied to form fields (which are rendered dynamically)

fix css styles and remove text-align, modify margin/madding left/right

BIDI to be applied to every elements inside article for post content

I've merged master back to this branch, would you like to work on fixing css before we merge this, or can we merge it, and this would be for a further pr?

> * [x] BIDI to be applied to form fields (which are rendered dynamically) > * [ ] fix css styles and remove text-align, modify margin/madding left/right > * [ ] BIDI to be applied to every elements inside article for post content I've merged master back to this branch, would you like to work on fixing css before we merge this, or can we merge it, and this would be for a further pr?

👍 1

ahangarha comentou (Migrado de github.com)

It you don't mind, merge it. I will send another PR for the following improvements.

👍 1

trinity-1686a aprovou estas alterações

trinity-1686a deixou um comentário

Proprietário

👍

:+1:

Revisores

trinity-1686a aprovou estas alterações

O pull request teve merge aplicado como 54c6d21fc5.

Você também pode ver as instruções para a linha de comandos.

Passo 1:

No repositório do seu projeto, crie um novo branch e teste as alterações.

git checkout -b add-rtl-support master

git pull origin add-rtl-support

Passo 2:

Faça merge das alterações e atualize no Forgejo.

git checkout master

git merge --no-ff add-rtl-support

git push origin master

Acesse para participar desta conversação.

Sem revisor

Sem marco

Sem responsável

2 participante(s)

Notificações

Data limite

A data limite é inválida ou está fora do intervalo. Por favor, use o formato 'dd/mm/aaaa'.

Data limite não informada.

Dependências

Nenhuma dependência definida.

Carregando…

Ainda não há conteúdo.

Etiquetas Marcos

WIP - initial RTL support #575 #577

Codecov Report

Revisores

Passo 1:

Passo 2: