Don't split sentences for translations #677

Merged

ryonakano merged 1 commits from no-split-sentences into master

ryonakano commented (Migrated from github.com)

Fixes #675

Also I've included the trailing period to the translatable string.

Fixes #675 Also I've included the trailing period to the translatable string.

codecov[bot] commented (Migrated from github.com)

Codecov Report

Merging #677 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #677   +/-   ##
=======================================
  Coverage   39.83%   39.83%           
=======================================
  Files          72       72           
  Lines        9368     9368           
  Branches     2219     2219           
=======================================
  Hits         3732     3732           
  Misses       4580     4580           
  Partials     1056     1056

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/677?src=pr&el=h1) Report > Merging [#677](https://codecov.io/gh/Plume-org/Plume/pull/677?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/006b44f580083f501c677b511c7c4d84f9848adf?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #677 +/- ## ======================================= Coverage 39.83% 39.83% ======================================= Files 72 72 Lines 9368 9368 Branches 2219 2219 ======================================= Hits 3732 3732 Misses 4580 4580 Partials 1056 1056 ```

igalic (Migrated from github.com) approved these changes

igalic (Migrated from github.com) left a comment

👍

elegaanz commented (Migrated from github.com)

The string should be updated on Crowdin too, now!

🎉 1

ryonakano commented (Migrated from github.com)

I should have escaped the href quotation marks 🙇‍♀️

![Screenshot from 2019-10-17 07-23-33](https://user-images.githubusercontent.com/26003928/66963614-0ed08380-f0af-11e9-8445-fd3656bead14.png) I should have escaped the href quotation marks :bowing_woman:

Reviewers

The pull request has been merged as fc9e69d811.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b no-split-sentences master

git pull origin no-split-sentences

Step 2:

Merge the changes and update on Forgejo.

git checkout master

git merge --no-ff no-split-sentences

git push origin master

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.

Labels Milestones

Don't split sentences for translations #677

Codecov Report

Reviewers

Step 1:

Step 2: