Mina Galić

igalic approved Plume/Plume#826

2020-10-08 10:42:35 +00:00

implement login via LDAP

👍

igalic commented on pull request Plume/Plume#826

2020-10-07 18:33:54 +00:00

implement login via LDAP

these…

igalic commented on pull request Plume/Plume#826

2020-10-07 18:33:54 +00:00

implement login via LDAP

can you please document where in this code we now fake the login check to prevent timing attacks?

igalic commented on pull request Plume/Plume#826

2020-10-07 18:33:54 +00:00

implement login via LDAP

…are going to be pain with async code

igalic commented on pull request Plume/Plume#826

2020-10-07 18:33:54 +00:00

implement login via LDAP

we should upgrade our own dependencies of these packages to 1.x

igalic commented on pull request Plume/Plume#826

2020-10-07 18:33:54 +00:00

implement login via LDAP

if addr and base_dn is_some()…

igalic commented on pull request Plume/Plume#826

2020-10-07 18:33:54 +00:00

implement login via LDAP

we panic, because both of those must be set??!

igalic commented on pull request Plume/Plume#826

2020-10-07 18:33:54 +00:00

implement login via LDAP

would it be possible to do these as if not tests, so we don't nest four levels deep until we get to the actual code.

igalic commented on pull request Plume/Plume#826

2020-10-07 18:33:54 +00:00

implement login via LDAP

if we use ldap as user-database, we could do the ldap bind once, and then pass around a connection…

igalic suggested changes for Plume/Plume#826

2020-10-07 18:33:54 +00:00

implement login via LDAP

i've looked at this now and have left a few comments.

igalic approved Plume/Plume#827

2020-10-07 18:00:04 +00:00

Remove link to unimplemented page(timeline edit)

if we can't expose timelines::edit as easy as we can get rid of this; then it's the right way to go.

igalic commented on pull request Plume/Plume#826

2020-10-03 16:49:58 +00:00

implement login via LDAP

-            // Making fake password verification to avoid different
-            // response times that would make it possible to know
-            // if a username is registered or not.
-            User::get(conn, 1)?.auth(&query.password);

why would you get rid of this?

igalic merged pull request Plume/Plume#825

2020-09-29 07:15:17 +00:00

CSS Fix: My title is displayed at the wrong position on Webkit browsers

igalic merged pull request Plume/Plume#825

2020-09-29 07:15:07 +00:00

CSS Fix: My title is displayed at the wrong position on Webkit browsers

igalic pushed to main at Plume/Plume

2020-09-29 07:15:06 +00:00

003dcf861a Merge pull request 'CSS Fix: My title is displayed at the wrong position on Webkit browsers' (#825) from quentin/Plume:pr/flex into main

5d8efa77a3 Fix title

Compare 2 commits »

igalic approved Plume/Plume#825

2020-09-28 11:14:54 +00:00

CSS Fix: My title is displayed at the wrong position on Webkit browsers

igalic commented on issue Plume/Plume#822

2020-09-18 13:27:28 +00:00

Upgrading from 0.4.0 to 0.5.0 results in rust panic

that last bit is a known issue Plume/Plume#789

igalic merged pull request plume/documentation#90

2020-09-14 21:01:58 +00:00

need libpq-dev lib for rpm-based distros, fix deprecated cargo command usage

igalic merged pull request plume/documentation#90

2020-09-14 21:01:55 +00:00

need libpq-dev lib for rpm-based distros, fix deprecated cargo command usage

igalic pushed to dev at plume/documentation

2020-09-14 21:01:54 +00:00

6d02554fc7 Merge pull request 'need libpq-dev lib for rpm-based distros, fix deprecated cargo command usage' (#90) from clasick/documentation:dev into dev

3bf54b4519 need --path explicitly specified

f561c23c80 fix typo

a64e9c882d need libpq-dev lib for Fedora

Compare 4 commits »