kiwii

kiwii closed issue plume/documentation#62

2020-07-24 17:59:32 +00:00

document which markdown flavor is used in Plume

kiwii pushed to dev at plume/documentation

2020-07-24 17:59:32 +00:00

3239b703ee Document markdown

51fa501fde A few style improvements

Compare 2 commits »

kiwii closed issue plume/documentation#80

2020-07-24 17:59:32 +00:00

Document supported programming languages

kiwii closed issue plume/documentation#71

2020-07-24 16:33:48 +00:00

Document the new matrix rooms

kiwii pushed to dev at plume/documentation

2020-07-24 16:33:48 +00:00

834b7297db Document new Matrix rooms

kiwii commented on pull request plume/documentation#89

2020-07-24 16:24:26 +00:00

Bump rack from 2.0.8 to 2.2.3

I have no idea, but I never configured it on GitHub, it came by itself.

kiwii deleted branch dependabot/bundler/rack-2.2.3 from plume/documentation

2020-07-24 16:22:23 +00:00

kiwii closed pull request plume/documentation#89

2020-07-24 16:07:55 +00:00

Bump rack from 2.0.8 to 2.2.3

kiwii pushed to refactor/extract-searcher-with-dbpool at igalic/Plume

2020-07-24 16:04:36 +00:00

0d8b8602ff Wrap Searcher in an Arc only in main

kiwii commented on pull request Plume/Plume#809

2020-07-24 15:33:01 +00:00

plume-model: refactor Searcher to have its own DbPool

It is a r2d2::Error, not the same as Diesel's one apparently. And I don't want to add another direct dependency in our Cargo.toml.

kiwii pushed to refactor/extract-searcher-with-dbpool at igalic/Plume

2020-07-24 15:29:32 +00:00

39ca7da3f0 Introduce Searcher::new

kiwii pushed to refactor/extract-searcher-with-dbpool at igalic/Plume

2020-07-24 13:42:06 +00:00

1c493713c9 Avoid unwrapping, return an Error instead

kiwii pushed to main at plume/gettext-macros

2020-07-24 12:27:50 +00:00

38f16d7418 Make it compile on stable

kiwii commented on pull request Plume/Plume#809

2020-07-24 10:12:20 +00:00

plume-model: refactor Searcher to have its own DbPool

I think all the previous ones are safe: we now it can't panic because we control the search index schema, we know that these fields exist (even if Rust can't check this at comoile-time). Here, we may fail to get a DB connection from the pool for whatever reason, and I think we should make the error "go up", so that the web UI or the CLI can display a proper error.

kiwii approved Plume/Plume#809

2020-07-23 18:35:11 +00:00

plume-model: refactor Searcher to have its own DbPool

👌

kiwii commented on pull request Plume/Plume#809

2020-07-23 18:35:10 +00:00

plume-model: refactor Searcher to have its own DbPool

Same here.

kiwii commented on pull request Plume/Plume#809

2020-07-23 18:35:10 +00:00

plume-model: refactor Searcher to have its own DbPool

I would prefer using ? instead of unwrap here.