• Joined on 2020-06-25
kiwii commented on pull request Plume/Plume#805 2020-07-19 12:08:58 +00:00
extract DbConn from PlumeRocket

I think you'll have to edit plume-models/src/config.rs so that Rocket knows the URL of this "plume" database.

kiwii merged pull request Plume/Plume#802 2020-07-19 12:04:43 +00:00
Recreate search index if its format is outdated
kiwii pushed to main at Plume/Plume 2020-07-19 12:04:43 +00:00
6de9a1f1c8 Merge pull request 'Recreate search index if its format is outdated' (#802) from KitaitiMakoto/Plume:invalid-index into main
5e30bede40 Don't care about needless return value of closures
5cca66b346 Add action user can take to error message
484659fde2 Run cargo fmt
5fc827c1c9 Re-initialize search index when recreating is failed
Compare 7 commits »
kiwii commented on issue Plume/Plume#799 2020-07-17 13:42:23 +00:00
[Refactoring] send messages to dedicated actor instead of directly accessing objects

Honestly, it makes me wonder if actix wouldn't be more appropriate for our use case… we would get actors and a web framework out of the box. I think we already tried to migrate once and it didn't went very far, right? What was blocking?

But I'm okay with refactoring our code with Riker and keeping Rocket too.

kiwii merged pull request Plume/Plume#800 2020-07-17 13:39:12 +00:00
upgrade rocket* to the latest stable
kiwii pushed to main at Plume/Plume 2020-07-17 13:39:12 +00:00
010eac6c4a Merge pull request 'upgrade rocket* to the latest stable' (#800) from igalic/Plume:update/rocket into main
a107d35492 upgrade rocket* to the latest stable
Compare 2 commits »
kiwii approved Plume/Plume#800 2020-07-17 13:38:55 +00:00
upgrade rocket* to the latest stable

👌

kiwii commented on pull request Plume/Plume#798 2020-07-15 11:04:28 +00:00
Drone CI

@trinity-1686a I don't know if you set up Drone with Docker, but it looks like /tmp/cache is not available, could you create a directory and mount it in Docker at this path, please? Or do an equivalent operation if you are not using Docker.

kiwii commented on pull request Plume/Plume#795 2020-07-15 10:48:31 +00:00
Drone CI config

Closing in favor of #797

kiwii closed pull request Plume/Plume#795 2020-07-15 10:48:31 +00:00
Drone CI config
kiwii pushed to drone-ci at Plume/Plume 2020-07-15 10:45:44 +00:00
614be45425 Dummy commit to retrigger the build
kiwii created pull request Plume/Plume#798 2020-07-15 10:42:44 +00:00
Drone CI
kiwii pushed to drone-ci at Plume/Plume 2020-07-15 10:42:13 +00:00
b26e785277 Continue the Drone CI config
kiwii commented on issue Plume/Plume#797 2020-07-15 09:46:45 +00:00
[Refactoring] Move DbConn out PlumeRocket

What I can tell out of my head is:

  • benefits:
    • we can clearly see which routes use the database, and which don't
    • we will probably have less custom code if we use the #[database] attribute that generates some code for us, I guess.
  • drawbacks:
    • not sure it is the case, but maybe we won't be able to migrate to sqlx with the #[database] attribute, I don't know what types SQLx supports, and if they are compatible with Rocket's attribute.
  • alternatives:
    • keeping it the way it is? but that makes the async migration harder, so it is not really an option

Clippy shouldn't be unhappy either, it is just one parameter, so I'm all

kiwii closed issue Plume/Plume#783 2020-07-05 16:31:26 +00:00
Adding font for Persian language
kiwii commented on issue Plume/Plume#783 2020-07-05 16:31:26 +00:00
Adding font for Persian language

This issue have been fixed as far as I can tell.

kiwii pushed to main at Plume/Plume 2020-07-05 16:18:08 +00:00
f9beb2383b Update lindera-tantivy to v0.1.3
7e78cffcaa Bump Docker base images to buster flavor (#797)
kiwii merged pull request Plume/Plume#796 2020-07-05 14:36:21 +00:00
Update lindera-tantivy to v0.1.3
kiwii pushed to master at Plume/Plume 2020-07-05 14:36:21 +00:00
6238bbd6c5 Merge pull request 'Update lindera-tantivy to v0.1.3' (#796) from KitaitiMakoto/Plume:update-lindera-tantivy into master
f28f4c1fad Update lindera-tantivy to v0.1.3
Compare 2 commits »
kiwii approved Plume/Plume#796 2020-07-05 14:36:16 +00:00
Update lindera-tantivy to v0.1.3

👍